Convert cluster client to a property #975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: runhouse/resources/hardware/cluster.py
Did you find this useful? React with a 👍 or 👎 |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @carolineechen and the rest of your teammates on |
carolineechen
force-pushed
the
cc/client-property
branch
3 times, most recently
from
b81a83e
to
33a1c25
Compare
This was referenced Jul 10, 2024
carolineechen
force-pushed
the
cc/client-property
branch
2 times, most recently
from
8b080a3
to
4fb3904
Compare
| @@ -616,7 +620,7 @@ def connect_server_client(self, force_reconnect=False): | |||
| # Connecting to localhost because it's tunneled into the server at the specified port. | |||
| # As long as the tunnel was initialized, | |||
| # self.client_port has been set to the correct port | |||
| self.client = HTTPClient( | |||
| self.http_client = HTTPClient( | |||
There was a problem hiding this comment.
Should this be private?
carolineechen
force-pushed
the
cc/client-property
branch
from
4fb3904
to
3a36209
Compare
carolineechen
force-pushed
the
cc/client-property
branch
from
3a36209
to
5071c04
Compare
carolineechen
force-pushed
the
cc/client-property
branch
from
5071c04
to
f78f4e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.